Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go docs #9992

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Update Go docs #9992

merged 5 commits into from
Sep 14, 2024
+189 −13

Conversation

cleptric
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 8:41am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 8:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 8:41am

@cleptric cleptric self-assigned this May 10, 2024
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 9.74kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 3.22kB ⬆️
sentry-docs-edge-server-array-push 257.07kB 60 bytes ⬆️
sentry-docs-client-array-push 6.4MB 6.46kB ⬆️

@cleptric cleptric changed the title Update Go Crons docs Update Go docs May 10, 2024
@cleptric cleptric mentioned this pull request May 10, 2024
Closed
3 tasks
vivianyentran
vivianyentran approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some copyedits but lgtm!

docs/platforms/go/guides/fiber/index.mdx Outdated Show resolved Hide resolved
docs/platforms/go/guides/fiber/index.mdx Outdated Show resolved Hide resolved
docs/platforms/go/guides/fiber/index.mdx Outdated Show resolved Hide resolved
docs/platforms/go/guides/fiber/index.mdx Outdated Show resolved Hide resolved
@getsantry getsantry bot added the Stale label Jun 1, 2024
@cleptric cleptric added WIP and removed Stale labels Jun 1, 2024
@getsentry getsentry deleted a comment from getsantry bot Jun 1, 2024
@cleptric cleptric marked this pull request as draft June 14, 2024 09:55
@cleptric cleptric marked this pull request as ready for review September 13, 2024 15:00
@cleptric cleptric enabled auto-merge (squash) September 13, 2024 15:00
ribice
ribice reviewed Sep 14, 2024
View reviewed changes
platform-includes/crons/setup/go.mdx

```go
// Create a monitor config object
monitorConfig := &sentry.MonitorConfig{
Schedule: monitorSchedule,
MaxRuntime: 2,
CheckInMargin: 1,
FailureIssueThreshold: 2,
Copy link
Collaborator

@ribice ribice Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these should be removed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@cleptric cleptric merged commit e6f1a1b into master Sep 14, 2024
12 checks passed
@cleptric cleptric deleted the go-updates branch September 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribice ribice ribice approved these changes

@vivianyentran vivianyentran vivianyentran approved these changes

Assignees

@cleptric cleptric

Labels
Platform: Go Product Area: SDKs - Web Backend Team: Web Backend SDKs team-web-sdk-backend WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cleptric @ribice @vivianyentran @stephanie-anderson